Skip to content
This repository was archived by the owner on Jul 10, 2023. It is now read-only.

First steps to allowing Linux to use EGL and OpenGLES#220

Closed
prashantgupta24 wants to merge 30 commits intoservo:masterfrom
R00ney:refactor_gle3
Closed

First steps to allowing Linux to use EGL and OpenGLES#220
prashantgupta24 wants to merge 30 commits intoservo:masterfrom
R00ney:refactor_gle3

Conversation

@prashantgupta24
Copy link
Copy Markdown

@prashantgupta24 prashantgupta24 commented Dec 7, 2015

Review on Reviewable

R00ney and others added 29 commits November 30, 2015 20:45
@R00ney
crate egl for both android/linux, add pub mod egl {}
a7ceb05
@R00ney
use egl::surface instead of android surface
9282815
@R00ney
make egl for struct and EGLImageNativeSurface
bdc7a46
@R00ney
add egl dependencies for linux
60e75e7
@R00ney
more stubs
bfa31b4
@prashantgupta24
created a blank from_es2() function for ES2 render api function call
2252ee1
@R00ney
NativeDisplay to GlxDisplayInfo, new enum NativeDisplay, new struct E…
49ea03c 
…glDisplayInfo
@R00ney
NativeDislpay
b4225a5
@R00ney
new NativeDislpay
1a1b2cf
@R00ney
fix typo
4ae78fa
@R00ney
fixed import isssue
0fa7612
@R00ney
changed NativeDisplay to import from linux and android, panic Destroy…
41c2a66 
…ImageKHR
@R00ney
fixed paramater types of several functions to NativeDisplay
2006c19
@R00ney
fixed struct GlxDisplayInfo impl
5c004f9
@R00ney
added GlxDisplay breakout to upload and destroy
57fc573
@R00ney
pub structs
9a6e271
@R00ney
EGLImage for both linux/android
3d16dfd
@R00ney
native_surface_property linux or android for EGLImage
fbc96d6
@R00ney
NativeDisplay struct GlxDisplayInfo bindings fixed
b0e4430
@R00ney
fixed typo on line 69
dff0f87
@R00ney
fixed typo on line 62
d2fa780
@R00ney
fixed platform_display_data to unwrapped NativeDisplay enum
5dea68a
@R00ney
fixed redunt code and typo
b50d1ce
@R00ney
added from_es2
0443786
@R00ney
tricking linker with link extern...
132c7cc
@R00ney
unpanicked TexImage2D
bdc5d12
@R00ney
fixed import BGRA
5b3363f
@prashantgupta24
made review comments
3ee9c48
@prashantgupta24
Fixed extra spaces
cd78d85
@glennw
Copy link
Copy Markdown
Member

glennw commented Dec 7, 2015

Reviewed 2 of 4 files at r1, 3 of 3 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

src/platform/egl/surface.rs, line 71 [r4] (raw file):
BGRA constant only exists on Linux - we'll need to apply the same trick I have done here (https://github.com/glennw/webrender/blob/master/src/device.rs#L16) to support BGRA on Linux and BGRA_EXT on Android.

src/platform/egl/surface.rs, line 85 [r4] (raw file):
Tabs -> spaces

Comments from the review on Reviewable.io

@glennw
Copy link
Copy Markdown
Member

glennw commented Dec 7, 2015

Just a few minor changes left - nearly there! :)

@glennw
Copy link
Copy Markdown
Member

glennw commented Dec 10, 2015

This looks good to me (well, it will still need a rebase + squash) - but I'd like to get @mrobinson to check over it too.

mrobinson
mrobinson reviewed Dec 14, 2015
View reviewed changes
src/platform/linux/surface.rs
Copy link
Copy Markdown
Member

@mrobinson mrobinson Dec 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should still be called GLX instead of Glx.

@mrobinson
Copy link
Copy Markdown
Member

mrobinson commented Dec 14, 2015

Looks good to me, apart from a few minor style and naming issues.

@gdamjan gdamjan mentioned this pull request Dec 22, 2015
Closed
@larsbergstrom larsbergstrom mentioned this pull request Dec 28, 2015
Merged
@jdm jdm mentioned this pull request Feb 27, 2016
Merged
@jdm
Copy link
Copy Markdown
Member

jdm commented Feb 27, 2016

Rebased, squashed and comments addressed in #232.

@jdm jdm closed this Feb 27, 2016
bors-servo pushed a commit that referenced this pull request Feb 28, 2016
Auto merge of #232 - jdm:egl_linux, r=glennw
3cb5df4 
Support EGL on non-Android Linux.

Rebase and squash of #220.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-layers/232)
<!-- Reviewable:end -->
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@prashantgupta24 @glennw @mrobinson @jdm @R00ney