Merged
Conversation
|
I didn't upstream this because I didn't realize these changes would work on stable rust with |
Contributor
Author
|
It does require nightly, but it seems that pathfinder has their own |
|
Hit this on my error on my ARM based Windows laptop from a different crate and this fix fixes things for me. Would approve of this being merged (or an indication of what needs to be done to be satisfied that this can be merged perhaps?). |
jdm
approved these changes
Mar 21, 2025
|
As this breaks plotters via the font-kit dependancy, a release would be very welcome! |
This was referenced May 15, 2025
osiewicz
pushed a commit
to zed-industries/zed
that referenced
this pull request
Jun 20, 2025
`pathfinder_simd` doesn't compile on nightly aarch64 right now, but that was fixed by servo/pathfinder#575 and updated on crates.io by servo/pathfinder#577. This PR simply updates the `pathfinder_simd` dependency to the version that contains these fixes. I verified that this compiles with nightly on my machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #571 by applying the changes found in https://github.com/theoparis/pathfinder. I'm not certain why @theoparis did not upstream these themself, but I would like this fix upstreamed, so I'm filing this.
I haven't tested this with versions of nightly before the rust commit that broke this code, so it might break those, but I expect there are more people are using the most recent version of nightly than people using versions that still work with pathfinder_simd.