Unwrap dynamically imported modules#13
Open
lmartins wants to merge 1 commit intoselfawarestudio:masterfrom
Open
Unwrap dynamically imported modules#13lmartins wants to merge 1 commit intoselfawarestudio:masterfrom
lmartins wants to merge 1 commit intoselfawarestudio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@estrattonbailey Hi Eric, sorry it took me a while to get to this, but played with a small change that I think is working pretty great to allow Webpack's dynamic imports.
This commit checks if the loaded instance is a promise, unwraps it if it is, and then instantiate the object as picoapp normally would.
#7
Thank you!