p#564 Refining one-click install handling#5570
Open
akleshchev wants to merge 3 commits intorelease/26.1.1from
Open
p#564 Refining one-click install handling#5570akleshchev wants to merge 3 commits intorelease/26.1.1from
akleshchev wants to merge 3 commits intorelease/26.1.1from
Conversation
akleshchev
force-pushed
the
andreyk/p564_refining
branch
2 times, most recently
from
14b4ea7 to
9bd31f9
Compare
akleshchev
force-pushed
the
andreyk/p564_refining
branch
from
9bd31f9 to
0107e2d
Compare
akleshchev
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows Velopack/NSIS migration path by cleaning up legacy NSIS shortcuts and registry entries, and expands the Release Notes gating logic so test builds can optionally show Release Notes.
Changes:
- Add a Windows-only cleanup routine to remove legacy NSIS Start Menu folder and Public Desktop shortcut.
- Remove a legacy uninstall registry key name to avoid stale/duplicate uninstall entries.
- Change
UpdaterShowReleaseNotesfrom boolean to tri-state (0/1/2) and update Release Notes display logic to optionally allow test builds.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
indra/newview/llvelopack.h |
Declares clear_nsis_links() for Windows builds. |
indra/newview/llvelopack.cpp |
Implements legacy NSIS shortcut cleanup and deletes the legacy uninstall key path. |
indra/newview/llstartup.cpp |
Invokes legacy link cleanup during NSIS-uninstall detection; updates Release Notes gating to use tri-state mode. |
indra/newview/app_settings/settings.xml |
Changes UpdaterShowReleaseNotes to S32 and documents the 0/1/2 semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.