Log failed delivery of crucial vewer-->simulator connection UDP messages#5568
Open
AndrewMeadows wants to merge 3 commits intodevelopfrom
Open
Log failed delivery of crucial vewer-->simulator connection UDP messages#5568AndrewMeadows wants to merge 3 commits intodevelopfrom
AndrewMeadows wants to merge 3 commits intodevelopfrom
Conversation
AndrewMeadows
commented
Mar 23, 2026
| gGotUseCircuitCodeAck = true; | ||
| } | ||
| } | ||
| }; |
Collaborator
Author
There was a problem hiding this comment.
This used to be a helper function but we're moving into this context as a lambda.
akleshchev
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix #5567 : we should log when crucial viewer-->simulator connection messages are not delivered since such events could be the cause of a failed login/teleport/region-cross.