Allow custom model configs in easy_colab#238
Open
mikeoliphant wants to merge 4 commits intosdatkinson:mainfrom
Open
Allow custom model configs in easy_colab#238mikeoliphant wants to merge 4 commits intosdatkinson:mainfrom
mikeoliphant wants to merge 4 commits intosdatkinson:mainfrom
Conversation
|
This would be great to have! |
|
Any news on this feature? Will this implementation be allowing two files of exact same length, ignore hashes and then disable auto alignment and checks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional parameter to "run()" that allows you to specify a "custom_model_config". This makes it very easy to experiment with model architectures while having the simplicity of the easy colab.
Particularly since the more complex colab is deprecated, this would add a lot more flexibility for online colab training.
Here is an example of how I'm using it:
https://github.com/mikeoliphant/nam-train/blob/main/train.ipynb