Skip to content

fix index cannot be reshaped with inner join#832

Merged
LucaMarconato merged 1 commit intoscverse:mainfrom
melonora:fix_829
Jan 15, 2025
Merged

fix index cannot be reshaped with inner join#832
LucaMarconato merged 1 commit intoscverse:mainfrom
melonora:fix_829

Conversation

@melonora
Copy link
Collaborator

closes #829

There was a problem when a mutable copy was created when performing an inner join. This was due to slicing using an Index which did not have the method .reshape. This is fixed in this PR by converting it to a list.

Tested on the squidpy notebook.

@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (4630fa1) to head (00caed6).
Report is 35 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #832   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          46       46           
  Lines        7166     7166           
=======================================
  Hits         6573     6573           
  Misses        593      593           
Files with missing lines Coverage Δ
src/spatialdata/_core/query/relational_query.py 90.78% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaMarconato LucaMarconato merged commit 39a10a1 into scverse:main Jan 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow up problem with join

2 participants