Fix bug with join with duplicate obs indices#822
Merged
LucaMarconato merged 4 commits intoscverse:mainfrom Jan 13, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 91.73% 91.75% +0.01%
==========================================
Files 46 46
Lines 7128 7130 +2
==========================================
+ Hits 6539 6542 +3
+ Misses 589 588 -1
🚀 New features to boost your workflow:
|
Contributor
|
Thanks @melonora for the quick fix 😊 |
Member
|
Thanks @melonora! I just added some more tests. In doing this I found a case in which |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #815
The current way the join works on main does not account for duplicate indices in
table.obs.index. This leads to a problem when performing the join as the indices are used to subset the table.The implemented fix here gets the indices of the masked elements and then does a boolean masking on the obs dataframe with the index reset. This retrieves the integer indices which can then be used for subsetting the table. The behaviour of matching rows stays unchanged with this change.
now gives:
