Skip to content

Preserve attrs on Dask DataFrame sample() #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LiudengZhang wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

Preserve attrs on Dask DataFrame sample() #1088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/spatialdata/models/_accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ def __repr__(self) -> str:
"copy",
"drop",
"map_partitions",
"sample",
"set_index",
]:
wrap_method_with_attrs(method_name=method_name, dask_class=DaskDataFrame)
Expand Down
9 changes: 9 additions & 0 deletions tests/models/test_accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,15 @@ def test_dataframe_set_index_preserves_attrs():
assert isinstance(result.attrs, AttrsAccessor)


def test_dataframe_sample_preserves_attrs():
"""Test that DataFrame.sample preserves attrs."""
df = dd.from_pandas(pd.DataFrame({"a": [1, 2, 3], "b": [4, 5, 6]}), npartitions=2)
df.attrs["key"] = "value"
result = df.sample(frac=0.5)
assert result.attrs["key"] == "value"
assert isinstance(result.attrs, AttrsAccessor)


# ============================================================================
# Series wrapped methods tests
# ============================================================================
Expand Down
Loading