Skip to content

feat: Adding support for Annbatch#3620

Open
ori-kron-wis wants to merge 20 commits intomainfrom
Ori-annbatch
Open

feat: Adding support for Annbatch#3620
ori-kron-wis wants to merge 20 commits intomainfrom
Ori-annbatch

Conversation

@ori-kron-wis
Copy link
Collaborator

No description provided.

@ori-kron-wis ori-kron-wis self-assigned this Nov 25, 2025
@ori-kron-wis ori-kron-wis added on-merge: backport to 1.4.x on-merge: backport to 1.4.x custom_dataloader PR 2932 labels Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 81.50289% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.69%. Comparing base (4acf2f7) to head (4b78f54).

Files with missing lines Patch % Lines
src/scvi/dataloaders/_custom_dataloaders.py 81.39% 32 Missing ⚠️

❌ Your patch check has failed because the patch coverage (81.50%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (4acf2f7) and HEAD (4b78f54). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (4acf2f7) HEAD (4b78f54)
integration 9 3
custom_dataloader 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3620       +/-   ##
===========================================
- Coverage   88.21%   72.69%   -15.53%     
===========================================
  Files         229      229               
  Lines       22622    22793      +171     
===========================================
- Hits        19957    16569     -3388     
- Misses       2665     6224     +3559     
Flag Coverage Δ
autotune ?
cuda ?
custom_dataloader 35.80% <81.50%> (+0.34%) ⬆️
integration 70.74% <27.16%> (-0.34%) ⬇️
internet ?
jax ?
macos ?
mlflow ?
nonjax ?
optional ?
private ?
resolution ?
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scvi/dataloaders/__init__.py 100.00% <100.00%> (ø)
src/scvi/dataloaders/_custom_dataloaders.py 86.24% <81.39%> (-2.03%) ⬇️

... and 80 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis marked this pull request as ready for review February 17, 2026 11:21
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ee2098c75

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

custom_dataloader PR 2932 on-merge: backport to 1.4.x on-merge: backport to 1.4.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant