unify logup sum across table/non-table chip#1282
Open
hero78119 wants to merge 1 commit intofeat/pi_hash_digestfrom
Open
unify logup sum across table/non-table chip#1282hero78119 wants to merge 1 commit intofeat/pi_hash_digestfrom
hero78119 wants to merge 1 commit intofeat/pi_hash_digestfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously logup sum for chips might be
addorsubdepends on chip kind.This PR unify all operation to
addso verifier flow become unify and simpledesign rationales
We encode the unification when derive claim tower and gkr-iop circuit. For logup
table, we togglemultiplicitywith negative while non-table it's remain same as usualThis design keep multiplicity in gkr-iop layer remain positive, and the optional negate are encoded in expression directly