Open
Conversation
- rename ProofInput.pi_evals to pi - remove pi_in_evals and instance_openings plumbing - drop recursion mles/raw_pi_num_variables fields and keep scalar PI conversion path
fe0b9e1 to
0f499a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates public input/output handling from raw public-io memory openings to a digest-based path and unifies PI plumbing across prover/verifier/recursion.
Design rationales
Changes Highlights
ceno_rt:commit(data: &[u8])commit_digest([u32; 8])CommitCtxfor incremental accumulation + finalize.PUB_IO_COMMITsyscall support end-to-end:ceno_emul/src/syscalls/pubio_commit.rsceno_zkvm/src/instructions/riscv/ecall/pubio_commit.rsPUBIO_DIGEST_IDX,PUBIO_DIGEST_U16_LIMBSquery_public_io_digest()andPubioCommitLayout.ProofInput.pireplacespub_io_evals/public-input MLE plumbingpi_in_evals,instance_openings,raw_pi_num_variables, and related split/eval paths.