Fix/not in wiktionary

[shabicha]

Contributor checklist

• This pull request is on a separate branch and not the main branch
• I have tested my code with the xcodebuild and swiftlint --strict commands as directed in the testing section of the contributing guide

---

Description

This pull request prepares Scribe-iOS for the migration from Wikidata to Wiktionary as the data source for translations. invalidCommandMsg has been replaced with two variables, invalidCommandMsgWikidata and invalidCommandMsgWiktionary.

Changes:

• CommandVariables.swift: replaced invalidCommandMsg with invalidCommandMsgWikidata and invalidCommandMsgWiktionary
• KeyboardViewController.swift: conjugate and plural errors use invalidCommandMsgWikidata, translate case uses invalidCommandMsgWiktionary
• KeyboardStyling.swift: updated condition to check for both new variables
• TestKeyboardStyling.swift: replaced testStyleBtnWithInvalidCommandMsg() with separate tests for Wikidata and Wiktionary messages

Notes:

• Hebrew currently lacks a specific translation for "Not in Wiktionary" & "Not in Wikidata"
• The return key path for translate currently still shows invalidCommandMsgWikidata, happy to add a state tracking variable so pressing return after a failed translation also shows "Not in Wiktionary" if needed
• Should I add the explanation text variables (WIKIDATA_1/2/3 and WIKTIONARY_1/2/3) to the language interface files, and create interface variable files for languages in Scribe-i18n but not in Scribe-iOS yet - similar to what was requested in the Android PR?

Related issue

• Closes Switch translation "Not in Wikidata" to "Not in Wiktionary" #597

[github-actions]

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and iOS rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

[github-actions]

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

• Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[github-actions]

First PR Commit Check

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
• The contributor's name and icon in remote commits should be the same as what appears in the PR
• If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo (can be set with git config --global user.email "GITHUB_EMAIL")