Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Thanks for the PR, @Femimat! Would you be able to fix the Android Instrumentation tests? :) |
|
Let us know if you need some support! |
|
@Femimat I have re-rerun the tests and I hope now the failed tests are visible in the workflow. |
|
Hi @andrewtavis and @angrezichatterbox, I’m currently looking into the failing test and will provide an update soon. |
|
Hi @andrewtavis and @angrezichatterbox, I've fixed the failing tests. The tests are now passing locally and in the CI pipeline. Ready for your review whenever you have a moment! |
I will be checking the PR now. Thanks :) |
angrezichatterbox
left a comment
There was a problem hiding this comment.
Hey @Femimat
Thanks for the PR.
Currently the increased text size is only visible in the settings page. Could you make sure it is visible on all the pages when the toggle is enabled.
|
You're right, I'll look into it and update the PR once I'm done. |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
I have implemented the Increase app text size option as requested. This included adding the toggle to the Settings screen, persisting the preference, and ensuring that text sizes across the app scale by 1.25x when enabled.
Related issue