Fix/wikidata to wiktionary

[Mounil2005]

Contributor checklist

• This pull request is on a separate branch and not the main branch
• I have tested my code with the ./gradlew lintKotlin detekt test command as directed in the testing section of the contributing guide

---

Description

This pull request prepares Scribe-Android for the migration from Wikidata to Wiktionary as the data source for translations. All string references have been updated from not_in_wikidata to not_in_wiktionary.

Main changes:

• Updated string key names across 17 language-specific string.xml files (Arabic, Bengali, German, Spanish, French, Hindi, Indonesian, Kannada, Korean, Marathi, Portuguese, Swedish, Tamil, Telugu, Turkish, and English)
• Updated KeyboardUIManager.kt to reference the new Wiktionary string keys
• Total of 54 string references updated (3 explanation strings × 18 files)

The string content itself remains unchanged as it will be updated separately. These changes ensure the app infrastructure is ready to display Wiktionary-related messages when the backend switches to that data source.

Related issue

• Switch translation "Not in Wikidata" to "Not in Wiktionary" #553

[github-actions]

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

[github-actions]

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

• Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • Tests may need to be reran as they're at times not deterministic

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[github-actions]

First PR Commit Check

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
  - The contributor's name and icon in remote commits should be the same as what appears in the PR
  - If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL")

[Mounil2005]

Hey, @andrewtavis pls review and let me know in case of any changes!

[andrewtavis]

Thanks for the PR here, @Mounil2005 :) We have a couple of instructions here based on a discussion we had in our most recent dev sync:

• Firstly, we need both the Not in Wikidata and Not in Wiktionary texts
• We also made the decision that we want these texts to no longer be in Scribe-i18n
  • This is where those XML texts are from
  • Reason for this is that these XML texts are presented to the user based on the device language, but we want these to be based on the keyboard language
  • You don't need to edit those files in Scribe-i18n, I'll remove them

Could you do the following:

• Set up variables for all of these texts in the interface variable files
  • const val INVALID_COMMAND_MSG_WIKIDATA = "Not in Wikidata"
  • const val INVALID_COMMAND_TEXT_WIKIDATA_1 = "FIRST_TEXT_ABOUT_WIKIDATA"
  • const val INVALID_COMMAND_TEXT_WIKIDATA_2 = "SECOND_TEXT_ABOUT_WIKIDATA"
  • const val INVALID_COMMAND_TEXT_WIKIDATA_3 = "THIRD_TEXT_ABOUT_WIKIDATA"
  • const val INVALID_COMMAND_MSG_WIKTIONARY = "Not in Wiktionary"
  • const val INVALID_COMMAND_TEXT_WIKTIONARY_1 = "FIRST_TEXT_ABOUT_WIKTIONARY"
  • const val INVALID_COMMAND_TEXT_WIKTIONARY_2 = "SECOND_TEXT_ABOUT_WIKTIONARY"
  • const val INVALID_COMMAND_TEXT_WIKTIONARY_3 = "THIRD_TEXT_ABOUT_WIKTIONARY"
• If we don't have a interface variables file for a language that we have in Scribe-i18n, feel free to make it and just add these variables for now
• We want the Wikidata version of this message to be shown to the user for conjugate and plural, and the Wiktionary version to be shown for the translate command
• Make sure that these texts are being displayed to the user in the language of the keyboard, not the device language

CC @catreedle and @angrezichatterbox 👋 Hope the above makes sense to you two :)

[Mounil2005]

Got it, working on it!

[Mounil2005]

Hey @andrewtavis, I have implemented the changes, pls let me know in case of any changes!!

[Mounil2005]

Hi @andrewtavis, just a gentle reminder about this PR. Happy to adjust anything needed, thanks!

[angrezichatterbox]

Hi @andrewtavis, just a gentle reminder about this PR. Happy to adjust anything needed, thanks!

Hey
Sorry for the delay. We would get to review it today :)

[andrewtavis]

Thanks for the reminder @Mounil2005 and thanks for the review request, @angrezichatterbox :) @angrezichatterbox, let me know if you have a moment to sit for a review of this later this week. I'll do a quick review now and maybe you can do the changes in the coming days, @Mounil2005?

[andrewtavis]

We don't need INVALID_COMMAND_MSG and INVALID_COMMAND_MSG_WIKTIONARY, so feel free to remove INVALID_COMMAND_MSG. Ideally these variables would be ordered as you have them with the Wikidata ones first.

[andrewtavis]

You can do this removal of INVALID_COMMAND_MSG for all files :)

[andrewtavis]

Can you revert all changes to the string.xml files? I'll remove these strings in Scribe-i18n and bring the new changes back in.

[andrewtavis]

Re the above comment, if you'd like to do a PR to Scribe-i18n as well to support with this, you could send along a PR that removes i18n.app.keyboard.not_in_wikidata.explanation_1, i18n.app.keyboard.not_in_wikidata.explanation_2 and i18n.app.keyboard.not_in_wikidata.explanation_3 from all of the JSON files :) Feel free to open this and we'll bring that in and then merge the changes there into this PR!

[andrewtavis]

And one final thing for now - we have the i18n.app.keyboard.not_in_wikidata.explanation_* texts for a lot of languages in Scribe-i18n:

Could you add an InterfaceVariables.kt variable for each of the languages that we currently don't have a file for and then define these three Wikidata string variables? No other changes are needed for these files. The purpose is that we save the strings that we've gotten from the localization community 😊

[andrewtavis]

Please let us know if you have any questions! Thanks for your efforts so far 😊

[andrewtavis]

@angrezichatterbox, would you be able to take a look at this and finalize it? We're basically done with the PR, but we have the issue that the 1x1 view with the Not in Wikidata and Not in Wiktionary messages stays on the screen after it's displayed to the user. I can also take a look at this in the coming days to finalize it.

@Mounil2005, you'd also be welcome to send along a fix! See the screenshot below for the issue:

[andrewtavis]

I'm going to bring this in as we have an update of Scribe-i18n on main that's now making it more difficult to bring other PRs in :) I'll make a new issue for the Not in... texts showing above the keyboard.

Thanks for your contribution, @Mounil2005! You'd be welcome to work on the new issue :)

[Mounil2005]

I'm going to bring this in as we have an update of Scribe-i18n on main that's now making it more difficult to bring other PRs in :) I'll make a new issue for the Not in... texts showing above the keyboard.

Thanks for your contribution, @Mounil2005! You'd be welcome to work on the new issue :)

Thanks @andrewtavis for merging this! I really appreciate the opportunity to contribute!

I've actually been working on understanding the full scope of the changes needed (the i18n translations, the string.xml reversions, and creating the InterfaceVariables.kt files for languages without them). I was planning to address the reviewer feedback, and I'm glad this foundation is now in place.

I'd definitely be interested in working on the new issue for the Not in... texts! Looking forward to continuing to contribute to Scribe 👍

[andrewtavis]

Great, @Mounil2005! I'll ping you in the new issue :)