Open
Conversation
See : http://mozart2.org/ matteo.dubuisson@student.uclouvain.be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I fixed a small bug #438 where black (not bright) things where invisible on some terminals like mine Konsole using the default theme and it could impact a lot of users. The color 'black' is a perfect match with the default background color making string looking exactly like a chain of spaces. More, when the blinking white cursor passes on it it just disappears and thus gives the impression nano has a bug. I fixed this as proposed by the author to make it cyan to resolve the issue, it's visible and appear more natural as comments with nano are often cyan I have the impression. But variable assignation lines in the .git/config were also cyan so it looked ugly so I just simply put it to white. Maybe I'm wrong but it seems to me much cleaner and readable that way I don't know what you thing ?
Commit file before :
Config file before :
Commit file after :
Config file after :
I hope it helps,
Thank you very much for you time,