Adapt tof lookup table error threshold to be per-component#248
Merged
Conversation
Member
|
Hasn't this been released already? |
jl-wynen
approved these changes
Mar 9, 2026
jl-wynen
requested changes
Mar 9, 2026
Member
Author
No |
Member
|
I have used them in scipp/essreflectometry#204. I updated ESSreduce to 26.3.1 and this made the tests fail without the threshold fix. |
Member
Author
|
No, we just needed to bump the version of essreduce to 26.3.1 here, not it works |
jl-wynen
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required after updates in scipp/essreduce#319
Draft as we wait for these changes to be released.