Allow disabled eager loading with EAGER_IMPORT=0#166
Merged
effigies merged 4 commits intoscientific-python:mainfrom Mar 5, 2026
Merged
Allow disabled eager loading with EAGER_IMPORT=0#166effigies merged 4 commits intoscientific-python:mainfrom
effigies merged 4 commits intoscientific-python:mainfrom
Conversation
effigies
requested changes
Mar 4, 2026
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Member
Author
Oh, yes, you're right; that would not have helped :) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 108 109 +1
Branches 19 19
=========================================
+ Hits 108 109 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefanv
commented
Mar 4, 2026
stefanv
commented
Mar 4, 2026
Member
Author
|
@effigies Are you happy with the current version? I'd like to make a release for scikit-image's use. |
effigies
approved these changes
Mar 5, 2026
Collaborator
|
Yup, thanks for the ping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the skimage CI, we had
EAGER_IMPORT=0mean lazy loading. Woops :)