Skip to content

Allow disabled eager loading with EAGER_IMPORT=0#166

Merged
effigies merged 4 commits intoscientific-python:mainfrom
stefanv:eager-disable-with-0
Mar 5, 2026
Merged

Allow disabled eager loading with EAGER_IMPORT=0#166
effigies merged 4 commits intoscientific-python:mainfrom
stefanv:eager-disable-with-0

Conversation

@stefanv
Copy link
Member

@stefanv stefanv commented Mar 4, 2026

In the skimage CI, we had EAGER_IMPORT=0 mean lazy loading. Woops :)

@stefanv stefanv added the type: Bug fix Something isn't working label Mar 4, 2026
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As proposed, this turns an absent or empty variable into True, inverting the existing logic.

One possible fix.

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@stefanv
Copy link
Member Author

stefanv commented Mar 4, 2026

As proposed, this turns an absent or empty variable into True, inverting the existing logic.

Oh, yes, you're right; that would not have helped :)

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ccddd44) to head (4aead86).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          108       109    +1     
  Branches        19        19           
=========================================
+ Hits           108       109    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefanv
Copy link
Member Author

stefanv commented Mar 5, 2026

@effigies Are you happy with the current version? I'd like to make a release for scikit-image's use.

@effigies
Copy link
Collaborator

effigies commented Mar 5, 2026

Yup, thanks for the ping.

@effigies effigies merged commit d6c3399 into scientific-python:main Mar 5, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: Bug fix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants