This repository was archived by the owner on Feb 20, 2019. It is now read-only.
Experiment to compile to 2.12 and cross to 2.11, drop 2.10.#451
Open
ekrich wants to merge 5 commits intoscala:0.11.xfrom
Open
Experiment to compile to 2.12 and cross to 2.11, drop 2.10.#451ekrich wants to merge 5 commits intoscala:0.11.xfrom
ekrich wants to merge 5 commits intoscala:0.11.xfrom
Conversation
- removed all the straight deprecations - added access to sun.misc.Unsafe in Util - removed in 2.12 - might be useful if anyone wants to resurrect the library
Author
|
This is the sign of |
|
You have a typo with "picking" instead of "pickling" in the second commit. It compiles afterwards. |
Author
|
Thanks for the tip, compiles now with 3 test failures. |
Author
|
The following 3 tests fail probably due to 2.12 lambda encoding differences.
CI worked for 2.11 (no test failures). CI does not support 2.12 compiling. Failed for 2.10 build (removed support from codebase) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiles except for benchmark and tests. If the build (
project/Util.scala) is changed to 2.11.8 only, everything compiles and the tests run so clearly there are some differences when using 2.12.1 that don't work. I suspect that there is still a reference toscala.concurrent.util.Unsafe.instance. This would work in 2.11 but not 2.12.Note: I used whitebox macros.