Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the vendored SQLite C headers/shims/extensions to align with SQLite 3.51.3 (downgrading from 3.52.0), removing APIs/options that only exist in 3.52+ and trimming some extension-provided SQL helper functions.
Changes:
- Downgrade
sqlite3.hversion metadata to 3.51.3 and remove 3.52-only constants/APIs from the public headers. - Remove 3.52-only extension entrypoints/macros from
sqlite3ext.h. - Remove
SQLITE_DBCONFIG_FP_DIGITSshim support and drop some decimal/ieee754 extension functions/overloads.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/CSQLite/include/sqlite3.h | Downgrades header version to 3.51.3; removes 3.52-only constants/docs and updates various API docs. |
| Sources/CSQLite/include/sqlite3ext.h | Removes 3.52-only extension API routine pointers and convenience macros. |
| Sources/CSQLite/include/csqlite_shims.h | Drops shim declaration for SQLITE_DBCONFIG_FP_DIGITS. |
| Sources/CSQLite/csqlite_shims.c | Drops shim implementation for SQLITE_DBCONFIG_FP_DIGITS. |
| Sources/CSQLite/decimal.c | Removes significant-digit rounding support and unregisters 2-arg decimal / decimal_exp overloads. |
| Sources/CSQLite/ieee754.c | Removes ieee754_to_int / ieee754_from_int functions and changes mantissa negation handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
182
to
+184
| isNeg = 1; | ||
| m = -m; | ||
| if( m<0 ) return; |
| ** to xCurrentTime() if xCurrentTimeInt64() is unavailable. | ||
| ** | ||
| ** ^The xSetSystemCall(), xGetSystemCall(), and xNextSystemCall() interfaces | ||
| ** ^The xSetSystemCall(), xGetSystemCall(), and xNestSystemCall() interfaces |
| ** one of the first argument of the [carray() table-valued function]. The | ||
| ** S parameter is a pointer to the [prepared statement] that uses the carray() | ||
| ** functions. I is the parameter index to be bound. P is a pointer to the | ||
| ** array to be bound, and N is the number of eements in the array. The |
Comment on lines
+11159
to
+11163
| ** The sqlite3_carray_bind(S,I,P,N,F,X) interface binds an array value to | ||
| ** one of the first argument of the [carray() table-valued function]. The | ||
| ** S parameter is a pointer to the [prepared statement] that uses the carray() | ||
| ** functions. I is the parameter index to be bound. P is a pointer to the | ||
| ** array to be bound, and N is the number of eements in the array. The |
Comment on lines
+11166
to
+11168
| ** indicate the datatype of the array being bound. The X argument is not a | ||
| ** NULL pointer, then SQLite will invoke the function X on the P parameter | ||
| ** after it has finished using P, even if the call to |
Comment on lines
871
to
875
| void (*xFunc)(sqlite3_context*,int,sqlite3_value**); | ||
| } aFunc[] = { | ||
| { "decimal", 1, 0, decimalFunc }, | ||
| { "decimal", 2, 0, decimalFunc }, | ||
| { "decimal_exp", 1, 1, decimalFunc }, | ||
| { "decimal_exp", 2, 1, decimalFunc }, | ||
| { "decimal_cmp", 2, 0, decimalCmpFunc }, |
| @@ -343,8 +311,6 @@ int sqlite3_ieee_init( | |||
| { "ieee754_exponent", 1, 2, ieee754func }, | |||
| { "ieee754_to_blob", 1, 0, ieee754func_to_blob }, | |||
| { "ieee754_from_blob", 1, 0, ieee754func_from_blob }, | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.