You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This passes an empty string '' to parseWorkspaceSchemaId. The old local implementation had a guard if (id === undefined) { return } that skipped validation entirely. If the library's parseWorkspaceSchemaId treats an empty string as an error (pushing "id argument is empty" to the errors array), this will cause schema list (without --id) to fail.
Verify: extractCreateWorkspaceManifest handles icon resolution without workDir
The old extractWorkspaceManifest(workspaces, workDir) in extractWorkspaceManifest.ts passed workDir into icon resolution (resolveIcon({..., workDir})). The new code in extractManifest.worker.ts:23 calls extractCreateWorkspaceManifest(workspace) with no workDir. If the library's implementation still requires a working directory to resolve local icon references (e.g. React components defined in local files), icon extraction could silently fail or return null for workspaces that previously had icons. Worth confirming the library handles this case.
extractManifestSchemaTypes removed from public _internal export
packages/@sanity/cli/src/exports/_internal.ts previously exported extractManifestSchemaTypes. This is a breaking change for any consumer that imports from @sanity/cli/_internal. If this export was intentionally public-facing, a deprecation path or a re-export from @sanity/schema/_internal may be needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces duplicate code with
@sanity/schema/_internalWhat to review
Anything I miss
Testing
Existing tests should suffice