Conversation
git-subtree-dir: phosh git-subtree-split: 62fde093044d90b82154e68a39feb8e6ea967ef5
git-subtree-dir: libphosh-rs git-subtree-split: 5a356759a8f087263c0656d6a11dce2e76cab551
Switch phrog to the vendored libphosh-rs path dependency with static linking enabled by default so local and packaged builds stop depending on a system libphosh install. Update the vendored static build path and packaging/docs to match current phosh schema naming and build requirements. Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Owner
Author
|
Keeping this as a draft until v0.53.0 is kicked out the door. |
Mark generated files to skip rustfmt where possible and align generated subclass/sys sources with current rustfmt output so cargo fmt --all --check passes. Also silence newly-unused import warnings in libphosh-sys so CI builds with -Dwarnings succeed. Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Keep static vendored builds as the default locally, but avoid forcing internal Meson builds on GitHub Actions where a compatible system libphosh is already preinstalled in the CI image. This keeps CI green while still allowing explicit override via PHROG_LIBPHOSH_BUILD_INTERNAL. Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
samcday
added
debs
Owner
Author
|
/packit build |
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Owner
Author
|
/packit build |
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Owner
Author
|
/packit build |
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Owner
Author
|
/packit build |
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Owner
Author
|
/packit build |
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Owner
Author
|
/packit build |
samcday
commented
Mar 16, 2026
| debhelper-compat (= 13), | ||
| dh-cargo, | ||
| meson, | ||
| ninja-build, |
Owner
Author
There was a problem hiding this comment.
slop? think we only need meson here
samcday
commented
Mar 16, 2026
| printf 'deb-src http://deb.debian.org/debian unstable main\n' > /etc/apt/sources.list.d/debian-src.list | ||
| apt-get update | ||
| eatmydata apt-get -y --no-install-recommends \ | ||
| build-dep phosh |
Owner
Author
There was a problem hiding this comment.
should be ./phosh, no? I think the current case will use the metadata from repo rather than our vendored tree.
We should also add a apt-get build-dep for ./libphosh-rs, maybe?
samcday
commented
Mar 16, 2026
Comment on lines
+78
to
+85
| python3 - <<'PY' | ||
| import subprocess | ||
|
|
||
| output = subprocess.check_output(["ldd", "target/debug/phrog"], text=True) | ||
| print(output) | ||
| if "libphosh" in output: | ||
| raise SystemExit("phrog is dynamically linked against libphosh") | ||
| PY |
Owner
Author
There was a problem hiding this comment.
bad slop - just use bash here gat dang
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Owner
Author
|
/packit build |
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Owner
Author
|
/packit build |
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Owner
Author
|
/packit build |
Signed-off-by: Sam Day <me@samcday.com> Assisted-by: gpt-5.1-codex
Owner
Author
|
/packit build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.