Set meaningful worksheet title for pivot table XLSX exports#83
Closed
NA-V10 wants to merge 2 commits intosahana:masterfrom
Closed
Set meaningful worksheet title for pivot table XLSX exports#83NA-V10 wants to merge 2 commits intosahana:masterfrom
NA-V10 wants to merge 2 commits intosahana:masterfrom
Conversation
Author
|
Thanks for reviewing! If any changes or adjustments are needed, I'd be happy to update the PR. |
Member
|
The fix looks right - however, I cannot merge this for two reasons:
So I have to ask you to redo this fix on a clean |
Author
|
Thanks for the review. I understand the issue now. I created a fresh branch from the correct base branch, cherry-picked only the relevant commit for this fix, and opened a new PR targeting Please take a look when you have time. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR sets a meaningful worksheet title for pivot table XLSX exports instead of using the default
"Sheet"name.Changes
"Report"if neither is availableExample
Before:
SheetAfter:
Number of ShipmentsSent QuantityNumber of Items