Skip to content

Set meaningful worksheet title for pivot table XLSX exports#83

Closed
NA-V10 wants to merge 2 commits intosahana:masterfrom
NA-V10:pivot-xlsx-sheet-title
Closed

Set meaningful worksheet title for pivot table XLSX exports#83
NA-V10 wants to merge 2 commits intosahana:masterfrom
NA-V10:pivot-xlsx-sheet-title

Conversation

@NA-V10
Copy link
Copy Markdown

@NA-V10 NA-V10 commented Mar 28, 2026

Overview

This PR sets a meaningful worksheet title for pivot table XLSX exports instead of using the default "Sheet" name.

Changes

  • Use the aggregated fact label as worksheet title when available
  • Fall back to the report title if needed
  • Fall back to "Report" if neither is available
  • Sanitize worksheet titles to remove invalid Excel characters
  • Truncate worksheet titles to Excel's 31-character limit

Example

Before:

  • Sheet

After:

  • Number of Shipments
  • Sent Quantity
  • Number of Items

@NA-V10
Copy link
Copy Markdown
Author

NA-V10 commented Mar 28, 2026

Thanks for reviewing! If any changes or adjustments are needed, I'd be happy to update the PR.

@nursix
Copy link
Copy Markdown
Member

nursix commented Mar 30, 2026

The fix looks right - however, I cannot merge this for two reasons:

  1. You submitted the pull request to the master branch, but pull requests are only accepted for the dev branch.
  2. This PR contains a commit for a previously dismissed issue, probably because you branched off your previous story branch rather than current dev.

So I have to ask you to redo this fix on a clean dev copy, and then re-submit the PR to the correct branch.
Please see our code contribution guideline how to do this - and also note the Best Practices section on that page.

@NA-V10
Copy link
Copy Markdown
Author

NA-V10 commented Apr 4, 2026

Thanks for the review. I understand the issue now.

I created a fresh branch from the correct base branch, cherry-picked only the relevant commit for this fix, and opened a new PR targeting dev without the unrelated dismissed issue commit.

Please take a look when you have time. Thanks again!

@nursix nursix closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants