Conversation
GeorgeTrenins
requested changes
Oct 29, 2025
Member
GeorgeTrenins
left a comment
GeorgeTrenins
left a comment
There was a problem hiding this comment.
take care of small-arg limits
docs/source/conf.py
Outdated
| 'sphinx.ext.viewcode', # This allows linking or embedding source code | ||
| 'sphinx_copybutton', # pip install sphinx-copybutton | ||
| 'sphinx_new_tab_link' | ||
| #'sphinx_new_tab_link' # HB: have problems with importing this |
Member
There was a problem hiding this comment.
I think you need to pip install something - try to solve this and update requirements.txt
Contributor
Author
There was a problem hiding this comment.
Actually its is already in the requirements, I just didn't install the new requirements file. It works as it is.
docs/source/open_paths/open_path.rst
Outdated
| function of delta (same length), is averaged over all qP_q1 | ||
| distances | ||
| """ | ||
| D, q = np.meshgrid(np.asarray(delta), np.asarray(qP_q1)) |
Member
There was a problem hiding this comment.
Implement the analytical D -> 0 limit. Optionally, consider the small qP_q1 limit as well
Contributor
Author
There was a problem hiding this comment.
D=0 and p=0 is implemented now. I don't really see the point of implementing qP_q1 = 0 as in practice during simulations one will never exactly encounter it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.