Skip to content

make responsive, add linkedin#6

Open
s4m-mo wants to merge 1 commit intomasterfrom
new
Open

make responsive, add linkedin#6
s4m-mo wants to merge 1 commit intomasterfrom
new

Conversation

@s4m-mo
Copy link
Copy Markdown
Owner

@s4m-mo s4m-mo commented Aug 15, 2024

Summary by Sourcery

Enhance the website's responsiveness by adjusting layout and visibility for different screen sizes, and add a LinkedIn link to the footer. Refine project descriptions for improved clarity.

New Features:

  • Add a LinkedIn link to the footer section of the website.

Enhancements:

  • Improve responsiveness of the landing page and other components by adjusting padding and visibility for different screen sizes.
  • Refine the description of the 'Econsumer' project for clarity and conciseness.

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ❌ Failed (Inspect) Aug 15, 2024 4:05pm

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Aug 15, 2024

Reviewer's Guide by Sourcery

This pull request implements responsive design changes and adds a LinkedIn link to the portfolio website. The changes focus on improving the layout for different screen sizes, adjusting text sizes, and modifying some visual elements for better responsiveness. The main modifications are in the landing section, project display, footer, and some CSS adjustments.

File-Level Changes

Files Changes
src/routes/+page.svelte Implemented responsive design for the landing section
src/lib/components/InfiniteHorizontalScroll.svelte Adjusted layout and text sizes in the project display component for better responsiveness
src/app.postcss Modified CSS styles for hover effects and follower element
src/lib/components/Footer.svelte Added LinkedIn link to the footer and renamed 'Code' section to 'Platforms'
src/lib/scripts/projects.ts Updated project description for Econsumer to be more concise

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sam-the-programmer - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using more flexible units (e.g., rem, em) instead of viewport-based units (vw, vmax) for better scalability across different devices in your responsive design.
  • The change in the 'Econsumer' project description makes it more concise, but it might be losing some important information. Consider finding a balance between brevity and informative content.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant