Add gRPC reflection-based discovery and h2c support#453
Merged
ryanfowler merged 6 commits intomainfrom Mar 20, 2026
Merged
Conversation
fetch() already calls applyGRPCDefaults before setupGRPC, making the call inside setupGRPC dead work.
loadDiscoverySchema already fetches the schema via SchemaForSymbol for the describe symbol. The fallback that retried the same call when lookupDescribeSymbol failed was dead code — it would return the same schema and fail identically.
h2c was unconditionally evaluated for all requests, meaning non-gRPC `--http 2 http://` requests would silently use cleartext HTTP/2. Gate shouldUseH2C on HasGRPCMode() and remove the misleading HTTPDefault to HTTP2 mapping that didn't match the client transport switch. Rename newGRPCClient to newClient since it serves all request types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--grpc-listand--grpc-describefor grpcurl-style service discovery--grpcautomatically use reflection when no local proto schema is providedh2csupport for gRPC calls and discoveryTesting
GOCACHE=/tmp/fetch-gocache go test -mod=mod ./internal/fetch ./internal/cli ./internal/clientGOCACHE=/tmp/fetch-gocache go test -mod=mod ./integration -run 'TestMain/grpc reflection discovery and calls'