fix: cargo install rustpatcher on MacOS fails with LLVM error #5
Merged
fix: cargo install rustpatcher on MacOS fails with LLVM error #5
Conversation
… removal for signing on macos
Owner
Author
|
for some reason
when run twice on macos works, once yields an error when running simple. |
Owner
Author
|
l64 apple linker always signs on arm: https://github.com/keith/ld64/blob/90cb020963ce62a84000b99362cbed36bd16adcd/src/ld/Options.cpp#L5683-L5685 |
Owner
Author
|
failing on windows: error[E0432]: unresolved import `nix::libc`
--> crates\rustpatcher\src\updater.rs:12:5
|
12 | use nix::libc;
| ^^^^^^^^^ no `libc` in the root
error[E0433]: failed to resolve: could not find `libc` in `nix`
--> crates\rustpatcher\src\updater.rs:183:28
|
183 | let res = nix::libc::execv(exe.as_ptr(), args.as_ptr());
| ^^^^ could not find `libc` in `nix`
Some errors have detailed explanations: E0432, E0433.
For more information about an error, try `rustc --explain E0432`.
error: could not compile `rustpatcher` (lib) due to 2 previous errors
Error: Process completed with exit code 101.will ignore for now and declare win as unsupported platform for the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cd rustpatcher/crates/rustpatcher/ git checkout macos-embed-region-error cargo build --release --example simple cargo run --release --bin rustpatcher sign ../../target/release/examples/simple --key-file ../../owner_key_example ../../target/release/examples/simple