Open
Conversation
theHamsta
commented
Mar 22, 2026
| #[pyclass(name = "MLDeviceTensor", skip_from_py_object)] | ||
| pub struct PyMLDeviceTensor { | ||
| pub(crate) handle: rustnn::tensor::DeviceTensorHandle, | ||
| destroyed: Arc<Mutex<bool>>, |
Author
There was a problem hiding this comment.
FromPyObject requires Clone. DeviceTensorHandle is not Clone at the moment. Would need to switch from Box<dyn backend> to Arc<dyn backend>
Author
|
|
This allows using pywebnn with Python 3.14 without needing to set any environment variables that allow usage with unknown Python versions.
Author
|
Seems that setuptools-rust is now recommended instead of the extension-module feature https://pyo3.rs/v0.28.2/features.html#extension-module |
Draft
mtavenrath
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows using pywebnn with Python 3.14 without needing to set any environment variables that allow usage with unknown Python versions.
All our dependencies are not up-to-date at the moment.
I'm not familiar to the project so I don't know whether I broke anything.
These tests are failing before and after the change.EDIT: was just because of missing
pytest-asyncio