Replace all IFLA_ parsing code with netlink-packet-route parsed data#13
Merged
cathay4t merged 2 commits intorust-netlink:mainfrom Apr 6, 2026
Merged
Replace all IFLA_ parsing code with netlink-packet-route parsed data#13cathay4t merged 2 commits intorust-netlink:mainfrom
IFLA_ parsing code with netlink-packet-route parsed data#13cathay4t merged 2 commits intorust-netlink:mainfrom
Conversation
All `IFLA_` in this project is parsed by netlink-packet-route now. Remove unused code. Signed-off-by: Gris Ge <fge@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the link attribute parsing logic in src/ip/link/detail.rs by removing manual constant definitions and custom parsing functions in favor of using native variants from the rtnetlink crate. A compilation error was identified regarding the variant name for the all-multicast attribute, which should be corrected to use 'Allmulti' instead of 'AllMulticast'.
| for nl_attr in nl_attrs { | ||
| match nl_attr { | ||
| LinkAttribute::Promiscuity(p) => promiscuity = *p, | ||
| LinkAttribute::AllMulticast(a) => allmulti = *a, |
There was a problem hiding this comment.
The variant name in netlink-packet-route (and re-exported by rtnetlink) for IFLA_ALLMULTI is Allmulti, not AllMulticast. Using AllMulticast will result in a compilation error.
Suggested change
| LinkAttribute::AllMulticast(a) => allmulti = *a, | |
| LinkAttribute::Allmulti(a) => allmulti = *a, |
Signed-off-by: Gris Ge <fge@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All
IFLA_in this project is parsed by netlink-packet-route now.Remove unused code.