build_author_map(): remove unused from parameter#96
Open
DanielEScherzer wants to merge 1 commit intorust-lang:masterfrom
Open
build_author_map(): remove unused from parameter#96DanielEScherzer wants to merge 1 commit intorust-lang:masterfrom
build_author_map(): remove unused from parameter#96DanielEScherzer wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
Author
|
Note that this will conflict with #95 - I'll rebase one of them after the other merges |
DanielEScherzer
force-pushed
the
unused-from
branch
from
b08bdd9 to
f57947e
Compare
Was always specified as an empty string, just remove the parameter and the logic for when it was anything else
DanielEScherzer
force-pushed
the
unused-from
branch
from
f57947e to
6ecd14f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was always specified as an empty string, just remove the parameter and the logic for when it was anything else