Remove Spans from HIR -- 1/N -- Span collection#72878
Closed
cjgillot wants to merge 10 commits intorust-lang:masterfrom
Closed
Remove Spans from HIR -- 1/N -- Span collection#72878cjgillot wants to merge 10 commits intorust-lang:masterfrom
cjgillot wants to merge 10 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step in rust-lang/compiler-team#294
Split out of #72015
This PR collects the spans in the AST when lowering it to HIR.
This collection constructs a
HirId -> Spanmap as eachHirIdis assigned.This map is rendered accessible to the world through a query,
and replaces the implementation of
tcx.hir().span(...).This PR needs a perf run.
r? @pnkfelix