Skip to content

Move generic arg/param validation to create_substs_for_generic_args to resolve various const generics issues#68434

Merged
bors merged 12 commits intorust-lang:masterfrom
varkor:astconv-mismatch-error
Feb 27, 2020
Merged

Move generic arg/param validation to create_substs_for_generic_args to resolve various const generics issues#68434
bors merged 12 commits intorust-lang:masterfrom
varkor:astconv-mismatch-error

Conversation

@varkor
Copy link
Copy Markdown
Contributor

@varkor varkor commented Jan 21, 2020

This changes some diagnostics, but I think they're around as helpful as the previous ones, and occur infrequently regardless.

Fixes #68257.
Fixes #68398.

r? @eddyb

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-const_generics `#![feature(const_generics)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Const generic parameters are allowed in the wrong position (causing ICEs). Cannot use generic const argument without {}, despite no conflict

10 participants