Handle const-checks for &mut outside of HasMutInterior#66654
Merged
bors merged 12 commits intorust-lang:masterfrom Dec 2, 2019
Merged
Handle const-checks for &mut outside of HasMutInterior#66654bors merged 12 commits intorust-lang:masterfrom
&mut outside of HasMutInterior#66654bors merged 12 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses this comment.
Const-checking relied on
HasMutInteriorto forbid&mutin a const context. This was strange because all we needed to do was look for anRvalue::Refwith a certainBorrowKind, whereas theQualiftraits are specifically meant to get the qualifs for a value. This PR removes that logic fromHasMutInteriorand moves it intocheck_consts::Validator.As a result, we can now properly handle qualifications for
statics, which had to be ignored previously since you can e.g. borrow a staticCellfrom anotherstatic. We also remove thederived_from_illegal_borrowlogic, since it is no longer necessary; we give good errors for subsequent reborrows/borrows of illegal borrows.