rustc_metadata: Privatize more things#66496
Merged
bors merged 10 commits intorust-lang:masterfrom Nov 20, 2019
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #66056.
The most notable change here is that
CrateMetadatais moved fromcstore.rstodecoder.rs.Most of uses of
CrateMetadatafields are in the decoder and uses ofroot: CrateRootand other fields are so intertwined with each other that it would be hard to move a part of them intocstore.rsto privatizeCrateMetadatafields, so we are going the other way round.cstore.rscan probably be dismantled now, but I'll leave this to some other day.Similarly, remaining
CrateMetadatafields can be privatized by introducing some getter/setter methods, but not today.r? @eddyb