Normalize all opaque types when converting ParamEnv to Reveal::All#65989
Merged
bors merged 4 commits intorust-lang:masterfrom Jul 31, 2020
Merged
Normalize all opaque types when converting ParamEnv to Reveal::All#65989bors merged 4 commits intorust-lang:masterfrom
bors merged 4 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we normalize a type using a ParamEnv with a reveal mode of
RevealMode::All, we will normalize opaque types to their underlying
types (e.g.
type MyOpaque = impl Foo->StructThatImplsFoo).However, the ParamEnv may still have predicates referring to the
un-normalized opaque type (e.g.
<T as MyTrait<MyOpaque>>). This cancause trait projection to fail, since a type containing normalized
opaque types will not match up with the un-normalized type in the
ParamEnv.To fix this, we now explicitly normalize all opaque types in
caller_bounds of a
ParamEnvwhen changing its mode toRevealMode::All. This ensures that all predicatse will refer to theunderlying types of any opaque types involved, allowing them to be
matched up properly during projection. To reflect the fact that
normalization is occuring,
ParamEnv::with_reveal_allis renamed toParamEnv::with_reveal_all_normalizedFixes #65918