Polonius: fix some cases of killed fact generation, and most of the ui test suite#62736
Merged
bors merged 29 commits intorust-lang:masterfrom Jul 25, 2019
Merged
Polonius: fix some cases of killed fact generation, and most of the ui test suite#62736bors merged 29 commits intorust-lang:masterfrom
killed fact generation, and most of the ui test suite#62736bors merged 29 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since basic Polonius functionality was re-enabled by @matthewjasper in #54468, some tests were still failing in the polonius compare-mode.
This PR fixes all but one test in the
uisuite by:killedrelation: Polonius would incorrectly reject some NLL-accepted code, because of these missingkilledfacts.-Z poloniusrequires full NLLs. Some others were also both failing with NLL and succeeding with Polonius, which we can't encode in tests at the moment.Fact generation changes:
CallterminatorsStorageDeadborrowed_placeconflicts with the current place.One failing test remains: an overflow during fact generation, on a case of polymorphic recursion (and which I'll continue investigating later).
This adds some tests for the fact generation changes, with some simple Polonius cases similar to the existing smoke tests, but also for some cases encountered in the wild (in the
randcrate for example).A more detailed write-up is available here with an explanation for each test failure, the steps taken to resolve it (as a commit in the current PR), NLL and Polonius outputs (and diff), etc.
Since they've worked on this before, and we've discussed some of these failures together:
r? @matthewjasper