Rollup of 7 pull requests by matthiaskrgr · Pull Request #153631 · rust-lang/rust

matthiaskrgr · 2026-03-09T22:47:05Z

Successful merges:

rustdoc: don't give depreciation notes special handling #149931 (rustdoc: don't give depreciation notes special handling)
ast_passes: unsupported arch w/ scalable vectors #153608 (ast_passes: unsupported arch w/ scalable vectors)
Add missing Diag::with_span_suggestion_with_style method #153609 (Add missing Diag::with_span_suggestion_with_style method)
Only lint unused features if they are unstable #153610 (Only lint unused features if they are unstable)
Update sysinfo version to 0.38.4 #153616 (Update sysinfo version to 0.38.4)
Update books #153619 (Update books)
Ping fmease on parser modifications #153624 (Ping fmease on parser modifications)

Emit an error when attempting to compile a `#[rustc_scalable_vector]` type for a architecture that fundamentally doesn't support scalable vectors. Ultimately this is just a diagnostic improvement for an internal attribute as users should never be doing this.

@GuillaumeGomez

…ure, r=GuillaumeGomez rustdoc: don't give depreciation notes special handling based on discussion in rust-lang#149741 we're currently using pre-wrap here which forces us to do a bunch of other hacky weird stuff, but getting rid of all that would likely break some existing docs, so i'm proposing we do it across an edition. r? @GuillaumeGomez

@lqd

…ture, r=lqd ast_passes: unsupported arch w/ scalable vectors Fixes rust-lang#153593 Emit an error when attempting to compile a `#[rustc_scalable_vector]` type for a architecture that fundamentally doesn't support scalable vectors. Ultimately this is just a diagnostic improvement for an internal attribute as users should never be doing this. r? @lqd

@JonathanBrouwer

…n_with_style, r=JonathanBrouwer Add missing `Diag::with_span_suggestion_with_style` method Uncovered while working on rust-lang#153509. r? @JonathanBrouwer

…-features, r=JonathanBrouwer Only lint unused features if they are unstable Fixes rust-lang#153523

Update `sysinfo` version to `0.38.4` r? ghost

Update books ## rust-embedded/book 4 commits in 99d0341ff4e06757490af8fceee790c4ede50bc0..e88aa4403b4bf2071c8df9509160477e40179099 2026-02-28 20:13:44 UTC to 2026-02-28 20:07:25 UTC - Clarify that a mini usb cable is used on the STM32F3DISCOVERY (rust-embedded/book#381) - Update outdated qemu documentation (rust-embedded/book#403) - Add TRACE32 to Debuggers section (rust-embedded/book#406) - Add a link to Rust for Zephyr (rust-embedded/book#407) ## rust-lang/nomicon 4 commits in b8f254a991b8b7e8f704527f0d4f343a4697dfa9..cc6a6bae8c3bfa389974e533c54694662c1a9de6 2026-02-27 23:27:18 UTC to 2026-02-26 22:57:03 UTC - Fix `Vec::push_all` ptr code in exception-safety (rust-lang/nomicon#418) - Clarify parameter and argument compatibility (rust-lang/nomicon#516) - Improve grammar in Variance section (rust-lang/nomicon#515) - Explicit `extern "C"` ABI for FFI (rust-lang/nomicon#520) ## rust-lang/reference 7 commits in 50a1075e879be75aeec436252c84eef0fad489f4..c49e89cc8c7c2c43ca625a8d5b7ad9a53a9ce978 2026-03-04 15:39:00 UTC to 2026-03-01 06:34:18 UTC - Resolve grammar rules in link reference definitions (rust-lang/reference#2198) - Support non-ASCII Unicode in grammar rule names (rust-lang/reference#2196) - Fix grammar for block comments (rust-lang/reference#2191) - Fix an EN grammar error & add an item to place expr context list (rust-lang/reference#2189) - Align attribute template with applied conventions (rust-lang/reference#2194) - Update shebang (rust-lang/reference#2192) - Remove RESERVED_NUMBER (rust-lang/reference#2193)

…r=fmease Ping fmease on parser modifications From time to time innocuous-seeming PRs get submitted and sometimes even approved that unbeknownst to their author and to reviewers change the grammar of (stable) Rust which would be a breaking change; often they only meant to tweak diagnostics. I sometimes catch such PRs before they get merged but I want to make it a lot harder for them to slip through the cracks going forward. I'm going to list recent examples to paint a picture (note: this is not about blame!): 1. rust-lang#149728 (review) (2026) * caught before merge but after approval * PR unapproved for now 2. rust-lang#152501 (2026) * caught after merge of rust-lang#149489 * fixed & backported 3. rust-lang#152499 (2026) * caught after merge of rust-lang#149667 * fixed & backported 4. rust-lang#151960 (comment) (2026) * caught right after submission * the approach was thus changed 5. rust-lang#148238 (2025) * caught after merge of rust-lang#118947 * still unaddressed 6. rust-lang#144386 (review) (2025) * caught right after submission * crater & T-lang were activated by me 7. rust-lang#119042 (comment) (2023) * caught right after submission * the approach was thus changed 8. rust-lang#103534 (2022) * caught way later * partially addressed Why not just post a note without pinging me? Well, due to them not failing CI and generally due to (friendly) botspam, such comments just get lost or sometimes even actively ignored. Of course, I'm not able to catch everything. E.g., I didn't notice issue rust-lang#146417 before PR rust-lang#139858 was merged despite having skimmed its diff and more importantly, I as a reviewer missed the blatantly obvious rust-lang#144958 before merge. Separately, off and on over the span of one year I've worked on a Rust parser that now has >99% accuracy/parity with rustc according to some metrics (this includes stable + unstable + internal syntax) and which I'm now using to detect such regressions and issues in general among other things (e.g., rust-lang#152499 and rust-lang#152820 were found this way, more to come). I'm pretty invested, let's say. r? me

matthiaskrgr · 2026-03-09T22:47:20Z

@bors r+ rollup=never p=5

rust-bors · 2026-03-09T22:47:23Z

📌 Commit 9b45a3c has been approved by matthiaskrgr

It is now in the queue for this repository.

rust-bors · 2026-03-10T06:19:04Z

☀️ Test successful - CI
Approved by: matthiaskrgr
Duration: 3h 6m 33s
Pushing 595f14b to main...

rust-timer · 2026-03-10T06:21:03Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#149931	rustdoc: don't give depreciation notes special handling	`d6c66f987913e37f9fdf925fe506d6ab52faf3de` (link)
#153608	ast_passes: unsupported arch w/ scalable vectors	`a967e27087e23ef85bd2d884ad7a5b46337b2f0f` (link)
#153609	Add missing `Diag::with_span_suggestion_with_style` method	`464bfe3ba676d69f71c6e63bbccf3a4f81e95646` (link)
#153610	Only lint unused features if they are unstable	`c44ee2e107e4ce55d94168c0c479a55033e57c72` (link)
#153616	Update `sysinfo` version to `0.38.4`	`10b3cd9a589275fe67c590e2b08ac2afbfdbecf3` (link)
#153619	Update books	`ba1a72fdd41bf7e4f57cdf104a1599074bcdeed7` (link)
#153624	Ping fmease on parser modifications	`d919c3e08500c1d07f539c633a0c4f8a81aeeaca` (link)

previous master: 2d76d9bc76

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-03-10T06:21:48Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2d76d9b (parent) -> 595f14b (this PR)

Test differences

Show 28 test diffs

Stage 1

[ui] tests/ui/lint/unused-features/stable-features.rs: [missing] -> pass (J1)
[ui] tests/ui/scalable-vectors/bad-architectures.rs: [missing] -> pass (J1)
[ui] tests/ui/scalable-vectors/fn-trait.rs: pass -> ignore (only executed when the architecture is aarch64) (J1)
[ui] tests/ui/scalable-vectors/illegal-init.rs: [missing] -> ignore (only executed when the architecture is aarch64) (J1)
[ui] tests/ui/scalable-vectors/illegal_init.rs: pass -> [missing] (J1)
[ui] tests/ui/scalable-vectors/illformed-element-type.rs: pass -> ignore (only executed when the architecture is aarch64) (J1)
[ui] tests/ui/scalable-vectors/illformed-tuples-of-scalable-vectors.rs: pass -> ignore (only executed when the architecture is aarch64) (J1)
[ui] tests/ui/scalable-vectors/illformed-within-types.rs: pass -> ignore (only executed when the architecture is aarch64) (J1)
[ui] tests/ui/scalable-vectors/illformed.rs: pass -> ignore (only executed when the architecture is aarch64) (J1)
[ui] tests/ui/scalable-vectors/invalid.rs: pass -> ignore (only executed when the architecture is aarch64) (J1)
[ui] tests/ui/scalable-vectors/wellformed-arrays.rs: pass -> ignore (only executed when the architecture is aarch64) (J1)
[ui] tests/ui/scalable-vectors/wellformed.rs: pass -> ignore (only executed when the architecture is aarch64) (J1)

Stage 2

[ui] tests/ui/scalable-vectors/bad-architectures.rs: [missing] -> ignore (ignored when the architecture is aarch64) (J0)
[ui] tests/ui/scalable-vectors/illegal-init.rs: [missing] -> pass (J0)
[ui] tests/ui/scalable-vectors/bad-architectures.rs: [missing] -> pass (J2)
[ui] tests/ui/scalable-vectors/fn-trait.rs: pass -> ignore (only executed when the architecture is aarch64) (J2)
[ui] tests/ui/scalable-vectors/illegal-init.rs: [missing] -> ignore (only executed when the architecture is aarch64) (J2)
[ui] tests/ui/scalable-vectors/illformed-element-type.rs: pass -> ignore (only executed when the architecture is aarch64) (J2)
[ui] tests/ui/scalable-vectors/illformed-tuples-of-scalable-vectors.rs: pass -> ignore (only executed when the architecture is aarch64) (J2)
[ui] tests/ui/scalable-vectors/illformed-within-types.rs: pass -> ignore (only executed when the architecture is aarch64) (J2)
[ui] tests/ui/scalable-vectors/illformed.rs: pass -> ignore (only executed when the architecture is aarch64) (J2)
[ui] tests/ui/scalable-vectors/invalid.rs: pass -> ignore (only executed when the architecture is aarch64) (J2)
[ui] tests/ui/scalable-vectors/wellformed-arrays.rs: pass -> ignore (only executed when the architecture is aarch64) (J2)
[ui] tests/ui/scalable-vectors/wellformed.rs: pass -> ignore (only executed when the architecture is aarch64) (J2)
[ui] tests/ui/lint/unused-features/stable-features.rs: [missing] -> pass (J3)
[ui] tests/ui/scalable-vectors/illegal_init.rs: pass -> [missing] (J3)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 595f14b02216a127df89326d03a7f4e22cd4067f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 3h 4m -> 1h 52m (-39.4%)
dist-apple-various: 2h 6m -> 1h 42m (-18.6%)
x86_64-gnu-llvm-21-2: 1h 24m -> 1h 39m (+17.4%)
aarch64-apple: 3h 22m -> 2h 51m (-15.6%)
dist-aarch64-msvc: 1h 48m -> 1h 34m (-12.9%)
dist-x86_64-llvm-mingw: 1h 54m -> 2h 3m (+8.0%)
x86_64-gnu-llvm-20-2: 1h 39m -> 1h 31m (-7.8%)
x86_64-gnu-aux: 2h 16m -> 2h 25m (+7.0%)
dist-various-1: 1h 8m -> 1h 13m (+6.7%)
x86_64-gnu-debug: 1h 57m -> 2h 5m (+6.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-03-10T07:01:08Z

Finished benchmarking commit (595f14b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 479.112s -> 478.928s (-0.04%)
Artifact size: 395.06 MiB -> 394.95 MiB (-0.03%)

lolbinarycat and others added 16 commits January 19, 2026 14:32

rustdoc: don't give depreciation notes special handling

438b126

Mark stable features as used to avoid trigger unused_features

2c7690e

Bless other tests

dfd5e90

Update sysinfo version to 0.38.4

28131e1

Update books

db5599b

Ping fmease on parser modifications

c5c8d6b

Add missing Diag::with_span_suggestion_with_style method

744c503

Use Diag::with_span_suggestion_with_style method in librustdoc

a4a37ed

Rollup merge of rust-lang#153609 - GuillaumeGomez:with_span_suggestio…

5b3d88d

…n_with_style, r=JonathanBrouwer Add missing `Diag::with_span_suggestion_with_style` method Uncovered while working on rust-lang#153509. r? @JonathanBrouwer

Rollup merge of rust-lang#153610 - mu001999-contrib:fix/unused-stable…

1aeecf0

…-features, r=JonathanBrouwer Only lint unused features if they are unstable Fixes rust-lang#153523

Rollup merge of rust-lang#153616 - GuillaumeGomez:update-sysinfo, r=lqd

b2265c7

Update `sysinfo` version to `0.38.4` r? ghost

rust-bors bot added the rollup A PR which is a rollup label Mar 9, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2026

rust-bors bot mentioned this pull request Mar 10, 2026

In Option::get_or_insert_with(), forget the None instead of dropping it. #148562

Open

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2026

rust-bors bot merged commit 595f14b into rust-lang:main Mar 10, 2026
12 checks passed

rustbot added this to the 1.96.0 milestone Mar 10, 2026

This was referenced Mar 10, 2026

Weekly cargo update #145516

Open

DRAFT: rustdoc: math-core LaTeX MathML test #151918

Draft

c-variadic: error when we can't guarantee that the backend does the right thing #152935

Open

various fixes for scalable vectors #153286

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests#153631

Rollup of 7 pull requests#153631
rust-bors[bot] merged 16 commits intorust-lang:mainfrom
matthiaskrgr:rollup-XDRwIkE

matthiaskrgr commented Mar 9, 2026

Uh oh!

matthiaskrgr commented Mar 9, 2026

Uh oh!

rust-bors bot commented Mar 9, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 10, 2026

Uh oh!

Uh oh!

rust-timer commented Mar 10, 2026

Uh oh!

github-actions bot commented Mar 10, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

matthiaskrgr commented Mar 9, 2026

Uh oh!

matthiaskrgr commented Mar 9, 2026

Uh oh!

rust-bors bot commented Mar 9, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 10, 2026

Uh oh!

Uh oh!

rust-timer commented Mar 10, 2026

Uh oh!

github-actions bot commented Mar 10, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Mar 10, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants