Port #[instruction_set] to attribute parser#150193
Merged
bors merged 1 commit intorust-lang:mainfrom Dec 31, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note the test changes, and deprecation of
E0778andE0779In my opinion, all errors related to this attribute are improved I think, except for if you have
#[instruction_set(arm::)]in which case there's anerror: expected identifier, found <eof>, which is quite unhelpful I think, but this seems to be a limitation of the general attribute parsing flowr? @JonathanBrouwer