Skip to content

compiler-builtins: Clean up features#142659

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
tgross35:builtins-features
Mar 31, 2026
Merged

compiler-builtins: Clean up features#142659
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
tgross35:builtins-features

Conversation

@tgross35
Copy link
Copy Markdown
Contributor

@tgross35 tgross35 commented Jun 18, 2025 •
edited
Loading

Remove the compiler-builtins feature from default because it prevents
testing via the default cargo test command. It made more sense as a
default when compiler-builtins was a dependency that some crates added
via crates.io, but is no longer needed.

The rustc-dep-of-std feature is also removed since it doesn't do
anything beyond what the compiler-builtins feature already does.

r? @ghost

@rustbot rustbot added A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 18, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35 tgross35 force-pushed the builtins-features branch from 89b4e61 to 802792b Compare June 18, 2025 07:10
bjorn3
bjorn3 reviewed Jun 18, 2025
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35 tgross35 force-pushed the builtins-features branch from 802792b to 5a5d4b8 Compare June 30, 2025 15:14
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@tgross35 tgross35 force-pushed the builtins-features branch from 5a5d4b8 to e74a507 Compare July 28, 2025 05:51
@rust-bors

This comment has been minimized.

Sign in to view
@tgross35
compiler-builtins: Clean up features
59fe28d 
Remove the `compiler-builtins` feature from default because it prevents
testing via the default `cargo test` command. It made more sense as a
default when `compiler-builtins` was a dependency that some crates added
via crates.io, but is no longer needed.

The `rustc-dep-of-std` feature is also removed since it doesn't do
anything beyond what the `compiler-builtins` feature already does.
@tgross35 tgross35 force-pushed the builtins-features branch from e74a507 to 59fe28d Compare March 30, 2026 22:46
@tgross35
Copy link
Copy Markdown
Contributor Author

tgross35 commented Mar 30, 2026

r? @Amanieu

@tgross35 tgross35 marked this pull request as ready for review March 30, 2026 22:48
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2026
@Amanieu
Copy link
Copy Markdown
Member

Amanieu commented Mar 30, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 30, 2026

📌 Commit 59fe28d has been approved by Amanieu

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2026
tgross35 added a commit to tgross35/rust that referenced this pull request Mar 30, 2026
@tgross35
Rollup merge of rust-lang#142659 - tgross35:builtins-features, r=Amanieu
0c8e23a 
compiler-builtins: Clean up features

Remove the `compiler-builtins` feature from default because it prevents
testing via the default `cargo test` command. It made more sense as a
default when `compiler-builtins` was a dependency that some crates added
via crates.io, but is no longer needed.

The `rustc-dep-of-std` feature is also removed since it doesn't do
anything beyond what the `compiler-builtins` feature already does.
@tgross35 tgross35 mentioned this pull request Mar 30, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Mar 31, 2026
@bors
Auto merge of #154611 - tgross35:rollup-I9ve7BM, r=tgross35
d60aa38 
Rollup of 7 pull requests

Successful merges:

 - #142659 (compiler-builtins: Clean up features)
 - #153574 (Avoid ICE when param-env normalization leaves unresolved inference variables)
 - #153648 (Fix EII function aliases eliminated by LTO)
 - #153790 (Fix regression when dealing with generics/values with unresolved inference)
 - #153893 (Lex lifetimes as identifiers, recover from emoji and emit appropriate error)
 - #153980 (refactor: move doc(rust_logo) check to parser)
 - #154551 (Skip suggestions pointing to macro def for assert_eq)
rust-bors bot pushed a commit that referenced this pull request Mar 31, 2026
@bors
Auto merge of #154611 - tgross35:rollup-I9ve7BM, r=tgross35
35ee928 
Rollup of 7 pull requests

Successful merges:

 - #142659 (compiler-builtins: Clean up features)
 - #153574 (Avoid ICE when param-env normalization leaves unresolved inference variables)
 - #153648 (Fix EII function aliases eliminated by LTO)
 - #153790 (Fix regression when dealing with generics/values with unresolved inference)
 - #153893 (Lex lifetimes as identifiers, recover from emoji and emit appropriate error)
 - #153980 (refactor: move doc(rust_logo) check to parser)
 - #154551 (Skip suggestions pointing to macro def for assert_eq)
tgross35 added a commit to tgross35/rust that referenced this pull request Mar 31, 2026
@tgross35
Rollup merge of rust-lang#142659 - tgross35:builtins-features, r=Amanieu
e98dac3 
compiler-builtins: Clean up features

Remove the `compiler-builtins` feature from default because it prevents
testing via the default `cargo test` command. It made more sense as a
default when `compiler-builtins` was a dependency that some crates added
via crates.io, but is no longer needed.

The `rustc-dep-of-std` feature is also removed since it doesn't do
anything beyond what the `compiler-builtins` feature already does.
@tgross35 tgross35 mentioned this pull request Mar 31, 2026
Closed
tgross35 added a commit to tgross35/rust that referenced this pull request Mar 31, 2026
@tgross35
Rollup merge of rust-lang#142659 - tgross35:builtins-features, r=Amanieu
7f00560 
compiler-builtins: Clean up features

Remove the `compiler-builtins` feature from default because it prevents
testing via the default `cargo test` command. It made more sense as a
default when `compiler-builtins` was a dependency that some crates added
via crates.io, but is no longer needed.

The `rustc-dep-of-std` feature is also removed since it doesn't do
anything beyond what the `compiler-builtins` feature already does.
@tgross35 tgross35 mentioned this pull request Mar 31, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 31, 2026
@JonathanBrouwer
Rollup merge of rust-lang#142659 - tgross35:builtins-features, r=Amanieu
bc47424 
compiler-builtins: Clean up features

Remove the `compiler-builtins` feature from default because it prevents
testing via the default `cargo test` command. It made more sense as a
default when `compiler-builtins` was a dependency that some crates added
via crates.io, but is no longer needed.

The `rustc-dep-of-std` feature is also removed since it doesn't do
anything beyond what the `compiler-builtins` feature already does.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 31, 2026
Closed
@tgross35 tgross35 mentioned this pull request Mar 31, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 31, 2026
@bors
Auto merge of #154633 - tgross35:rollup-Yvmg0Vs, r=tgross35
e4fdb55 
Rollup of 9 pull requests

Successful merges:

 - #154582 (miri subtree update)
 - #142659 (compiler-builtins: Clean up features)
 - #153574 (Avoid ICE when param-env normalization leaves unresolved inference variables)
 - #153648 (Fix EII function aliases eliminated by LTO)
 - #153790 (Fix regression when dealing with generics/values with unresolved inference)
 - #154551 (Skip suggestions pointing to macro def for assert_eq)
 - #154574 (delete several `ui/consts` tests)
 - #154577 (Update `mir-opt` 64-bit panic-abort tests for `Alignment` rename)
 - #154579 (remove debug requirement from hooks)
@rust-bors rust-bors bot merged commit e1d917a into rust-lang:main Mar 31, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 31, 2026
rust-timer added a commit that referenced this pull request Mar 31, 2026
@rust-timer
Unrolled build for #142659
307460d 
Rollup merge of #142659 - tgross35:builtins-features, r=Amanieu

compiler-builtins: Clean up features

Remove the `compiler-builtins` feature from default because it prevents
testing via the default `cargo test` command. It made more sense as a
default when `compiler-builtins` was a dependency that some crates added
via crates.io, but is no longer needed.

The `rustc-dep-of-std` feature is also removed since it doesn't do
anything beyond what the `compiler-builtins` feature already does.
github-actions bot pushed a commit to rust-lang/compiler-builtins that referenced this pull request Mar 31, 2026
@bors
Auto merge of #154633 - tgross35:rollup-Yvmg0Vs, r=tgross35
151ef9c 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#154582 (miri subtree update)
 - rust-lang/rust#142659 (compiler-builtins: Clean up features)
 - rust-lang/rust#153574 (Avoid ICE when param-env normalization leaves unresolved inference variables)
 - rust-lang/rust#153648 (Fix EII function aliases eliminated by LTO)
 - rust-lang/rust#153790 (Fix regression when dealing with generics/values with unresolved inference)
 - rust-lang/rust#154551 (Skip suggestions pointing to macro def for assert_eq)
 - rust-lang/rust#154574 (delete several `ui/consts` tests)
 - rust-lang/rust#154577 (Update `mir-opt` 64-bit panic-abort tests for `Alignment` rename)
 - rust-lang/rust#154579 (remove debug requirement from hooks)
chenyukang pushed a commit to chenyukang/rust that referenced this pull request Apr 1, 2026
@bors @chenyukang
Auto merge of rust-lang#154633 - tgross35:rollup-Yvmg0Vs, r=tgross35
fd830fc 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#154582 (miri subtree update)
 - rust-lang#142659 (compiler-builtins: Clean up features)
 - rust-lang#153574 (Avoid ICE when param-env normalization leaves unresolved inference variables)
 - rust-lang#153648 (Fix EII function aliases eliminated by LTO)
 - rust-lang#153790 (Fix regression when dealing with generics/values with unresolved inference)
 - rust-lang#154551 (Skip suggestions pointing to macro def for assert_eq)
 - rust-lang#154574 (delete several `ui/consts` tests)
 - rust-lang#154577 (Update `mir-opt` 64-bit panic-abort tests for `Alignment` rename)
 - rust-lang#154579 (remove debug requirement from hooks)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@Amanieu Amanieu

Labels

A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tgross35 @rust-log-analyzer @Amanieu @bjorn3 @rustbot