Implement pin!() using super let#139114
Merged
bors merged 4 commits intorust-lang:masterfrom Apr 19, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue for super let: #139076
This uses
super letto implementpin!().This means we can remove the hack we had to put in to fix #138596.
It also means we can remove the original hack to make
pin!()work, which used a questionable public-but-unstable field rather than a proper private field.While
super letis still unstable and subject to change, it seems safe to assume that future Rust will always have a way to expresspin!()in a compatible way, consideringpin!()is already stable.It'd help the experiment to have
pin!()usesuper let, so we can get some more experience with it.