Skip to content

Remove dead rustc_allowed_through_unstable_modules for std::os::fd contents#135491

Merged
bors merged 2 commits intorust-lang:masterfrom
RalfJung:remove-dead-rustc_allowed_through_unstable_modules
Jan 20, 2025
Merged

Remove dead rustc_allowed_through_unstable_modules for std::os::fd contents#135491
bors merged 2 commits intorust-lang:masterfrom
RalfJung:remove-dead-rustc_allowed_through_unstable_modules

Conversation

@RalfJung
Copy link
Copy Markdown
Member

@RalfJung RalfJung commented Jan 14, 2025

As far as I was able to reconstruct, the history here is roughly as follows:

I did a grep for pub use crate::os::fd and all the re-exports I could find are in stable modules. So given all that, we can remove the rustc_allowed_through_unstable_modules (hoping they are not also re-exported somewhere else, it's really hard to be sure about this).

I have checked that std still builds after this PR on the wasm32-wasip2 target.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-wasi Operating system: Wasi, Webassembly System Interface S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression on nightly when compiling mio for wasm32-wasi

4 participants