Revert 133858 due to perf regression#135263
Closed
lqd wants to merge 1 commit intorust-lang:masterfrom
Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares a revert of #133858 due to the unexpected perf regressions.
cc PR author @dianne and reviewer @lcnr
Opening as draft to leave some time for @dianne to take a look in case the fix is obvious. If not, or if they don't have time to look into it soon, we can land this revert. Once the issue is fixed in the original PR we can reland it with ease.