Skip to content

Test codegen when setting deployment target#130068

Merged
bors merged 1 commit intorust-lang:masterfrom
madsmtm:deployment-target-test
Sep 9, 2024
Merged

Test codegen when setting deployment target#130068
bors merged 1 commit intorust-lang:masterfrom
madsmtm:deployment-target-test

Conversation

@madsmtm
Copy link
Copy Markdown
Contributor

@madsmtm madsmtm commented Sep 7, 2024

Test our codegen in different scenarios when setting the deployment target. There are many places here where this is still incorrect, these will be fixed in #129342, #129367 and #129369. See #129432 for the bigger picture.

Tested locally using:

./x test tests/run-make/apple-deployment-target --target="aarch64-apple-darwin,aarch64-apple-ios,aarch64-apple-ios-macabi,aarch64-apple-ios-sim,aarch64-apple-tvos,aarch64-apple-tvos-sim,aarch64-apple-visionos,aarch64-apple-visionos-sim,aarch64-apple-watchos,aarch64-apple-watchos-sim,arm64_32-apple-watchos,armv7s-apple-ios,i386-apple-ios,x86_64-apple-darwin,x86_64-apple-ios,x86_64-apple-ios-macabi,x86_64-apple-tvos,x86_64-apple-watchos-sim,x86_64h-apple-darwin"

The only Apple targets that aren't tested by the above command are:

But all of this is as it was before this PR.

Fixes #47825, since we now have a test that compiles a dylib for aarch64-apple-ios.

Split out from #129342, see that for a little bit of the review that this has gone through already.

r? petrochenkov

@rustbot label O-apple

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc O-apple Operating system: Apple / Darwin (macOS, iOS, tvOS, visionOS, watchOS) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

rustc ICE when compiling a dylib/cdylib for aarch64-apple-ios

5 participants