Make ast MutVisitor have the same method name and style as Visitor#127524
Merged
bors merged 10 commits intorust-lang:masterfrom Jul 24, 2024
Merged
Make ast MutVisitor have the same method name and style as Visitor#127524bors merged 10 commits intorust-lang:masterfrom
MutVisitor have the same method name and style as Visitor#127524bors merged 10 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't map 100% because some
MutVisitormethods can filter or even expand to multiple items, but consistency seems nicer.tracking issue: #127615