match lowering: Hide Candidate from outside the lowering algorithm#127159
Merged
bors merged 5 commits intorust-lang:masterfrom Aug 1, 2024
Merged
match lowering: Hide Candidate from outside the lowering algorithm#127159bors merged 5 commits intorust-lang:masterfrom
Candidate from outside the lowering algorithm#127159bors merged 5 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internals of
Candidateare tricky and a source of confusion. This PR makes it so we don't exposeCandidates outside the lowering algorithm. Now:lower_match_tree;lower_match_treetakes a list of patterns as input;lower_match_treereturns a flat datastructure that contains only the necessary information.r? @matthewjasper
try-job: x86_64-rust-for-linux