Port tests/run-make/sysroot-crates-are-unstable from Python to rmake#126231
Closed
Zalathar wants to merge 1 commit intorust-lang:masterfrom
Closed
Port tests/run-make/sysroot-crates-are-unstable from Python to rmake#126231Zalathar wants to merge 1 commit intorust-lang:masterfrom
tests/run-make/sysroot-crates-are-unstable from Python to rmake#126231Zalathar wants to merge 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: See #129071 for a much simpler migration that doesn't try to get rid of the Python script.
(I would still like to finish porting the Python script at some point, but that doesn't have to be tied to the Makefile migration.)
Part of the run-make Makefile purge (#121876), and also the Python purge (#110479).
This is a relatively complex script by run-make standards, and it's not a direct 1:1 port, though I did try to retain all the functionality of the old script (such as reporting all errors instead of just the first one).
It's a bit annoying that reporting all errors requires so much extra plumbing.
While reviewing this just before posting, I realised that I neglected to port the
set_ld_lib_pathstuff (#89033), so marking this as draft until I've had a chance to look into that.