Skip to content

Disable SimplifyToExp in MatchBranchSimplification#124156

Merged
bors merged 1 commit intorust-lang:masterfrom
dianqk:disable-match_branches
Apr 20, 2024
Merged

Disable SimplifyToExp in MatchBranchSimplification#124156
bors merged 1 commit intorust-lang:masterfrom
dianqk:disable-match_branches

Conversation

@dianqk
Copy link
Copy Markdown
Member

@dianqk dianqk commented Apr 19, 2024

Due to the miscompilation mentioned in #124150, We need to disable MatchBranchSimplification temporarily.

To fully resolve this issue, my plan is:

  1. Disable SimplifyToExp in MatchBranchSimplification (this PR).
  2. Remove all potentially unclear transforms in Don't perform unsigned comparisons for signed integers  #124122.
  3. Gradually add back the removed transforms (possibly multiple PRs).

r? @Nilstrieb or @oli-obk

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants