Add PidFd::{kill, wait, try_wait}#124101
Merged
bors merged 2 commits intorust-lang:masterfrom Jun 22, 2024
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#117957 changed
Childkill/wait/try_wait to use its pidfd instead of the pid, when one is available.This PR extracts those implementations and makes them available on
PidFddirectly.The
PidFdimplementations differ significantly from the correspondingChildmethods:Childunless something stole the zombie childExitStatusis not kept, meaning that only the first time a wait succeeds it will be returnedwaitdoes not close stdinwaitonly requires&selfinstead of&mut selfsince there is no state to maintain and subsequent calls are safeTracking issue: #82971