Avoid allocas in codegen for simple mir::Aggregate statements#123886
Merged
bors merged 3 commits intorust-lang:masterfrom May 10, 2024
Merged
Avoid allocas in codegen for simple mir::Aggregate statements#123886bors merged 3 commits intorust-lang:masterfrom
allocas in codegen for simple mir::Aggregate statements#123886bors merged 3 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core idea here is to remove the abstraction penalty of simple newtypes in codegen.
Even something simple like constructing a
forces an
allocato be generated in nightly right now.Certainly LLVM can optimize that away, but it would be nice if it didn't have to.
Quick example:
on nightly we produce https://rust.godbolt.org/z/zcvoM79ae
but after this PR we produce
(even before the optimizer runs).