Allow partially moved values in match#103208
Merged
bors merged 6 commits intorust-lang:masterfrom Oct 27, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to unify the behaviour between
let _ = PLACE,let _: TY = PLACE;andmatch PLACE { _ => {} }.The logical conclusion is that the
matchversion should not check for uninitialised places nor check that borrows are still live.The
match PLACE {}case is handled by keeping aFakeReadin the unreachable fallback case to verify thatPLACEhas a legal value.Schematically,
match PLACE { arms }in surface rust becomes in MIR:match *borrow { _ => {} }continues to check that*borrowis live, but does not read the value.match *borrow {}both checks that*borrowis live, and fake-reads the value.Continuation of
#102256#104844Fixes #99180 #53114